handavid commented on code in PR #1177:
URL: https://github.com/apache/knox/pull/1177#discussion_r2954853708
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/backend/LdapProxyBackend.java:
##########
@@ -445,7 +459,11 @@ private void copyAttribute(Entry source, Entry target,
String attributeName) thr
if (attr != null) {
// Copy all values of the attribute (important for multi-valued
attributes like objectClass)
for (org.apache.directory.api.ldap.model.entry.Value value : attr)
{
- target.add(attributeName, value.getString());
+ try {
+ target.add(attributeName, value.getString());
+ } catch (Exception e) {
+ LOG.ldapAttributeCopyError(e);
Review Comment:
right. I was conflicted about this behavior also. The problem I was
originally solving was that the entry is omitted from search results if we
request an attribute that isn't defined in the proxy schema. Let me re-check
this behavior now that I've fixed the proxy schema to include both `memberOf`
and `sAMAccountName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
