handavid commented on code in PR #1177:
URL: https://github.com/apache/knox/pull/1177#discussion_r2954864171


##########
gateway-server/src/main/java/org/apache/knox/gateway/services/ldap/GroupLookupInterceptor.java:
##########
@@ -44,6 +44,7 @@ public class GroupLookupInterceptor extends BaseInterceptor {
     private LdapBackend backend;
     private static final Pattern UID_PATTERN = 
Pattern.compile(".*\\(uid=([^)]+)\\).*");
     private static final Pattern CN_PATTERN = 
Pattern.compile(".*\\(cn=([^)]+)\\).*");
+    private static final Pattern SAMAACCOUNTNAME_PATTERN = 
Pattern.compile(".*\\(sAMAccountName=([^)]+)\\).*");

Review Comment:
   There's a name normalizing filter somewhere in the interceptor chain prior 
to this point. The filter will have the normalized `sAMAccountName` string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to