[
https://issues.apache.org/jira/browse/KNOX-3278?focusedWorklogId=1019719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1019719
]
ASF GitHub Bot logged work on KNOX-3278:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/26 17:54
Start Date: 11/May/26 17:54
Worklog Time Spent: 10m
Work Description: pzampino commented on code in PR #1181:
URL: https://github.com/apache/knox/pull/1181#discussion_r3220988556
##########
gateway-shell-release/home/bin/knoxshell.sh:
##########
@@ -81,7 +81,7 @@ function main {
checkJava
buildAppJavaOpts
- $JAVA "${APP_JAVA_OPTS[@]}"
-Dlog4j.configurationFile=conf/knoxshell-log4j2.xml
-javaagent:"$APP_BIN_DIR"/../lib/aspectjweaver.jar -cp "$APP_JAR":lib/*
org.apache.knox.gateway.shell.Shell "$@" || exit 1
+ $JAVA "${APP_JAVA_OPTS[@]}"
-Dlog4j.configurationFile=conf/knoxshell-log4j2.xml
-javaagent:"$APP_BIN_DIR"/../lib/aspectjweaver.jar -cp "$APP_JAR":lib/* -cp
"$APP_JAR":lib/* org.apache.knox.gateway.launcher.Launcher "$@" || exit 1
Review Comment:
Why the change from shell.Shell to launcher.Launcher?
##########
gateway-shell/src/main/java/org/apache/knox/gateway/shell/commands/AbstractKnoxShellCommand.java:
##########
@@ -74,8 +94,70 @@ protected String
getBindingVariableNameForResultingTable(List<String> args) {
}
protected CredentialCollector login() throws CredentialCollectionException {
- KnoxLoginDialog dlg = new KnoxLoginDialog();
- dlg.collect();
- return dlg;
+ LineReader reader = LineReaderBuilder.builder()
Review Comment:
This appears to be a re-implementation of the credential collector logic in
the name of the JLine upgrade? Is it necessary for the dependency upgrade?
Issue Time Tracking
-------------------
Worklog Id: (was: 1019719)
Time Spent: 40m (was: 0.5h)
> Update jline to 3.30.6
> ----------------------
>
> Key: KNOX-3278
> URL: https://issues.apache.org/jira/browse/KNOX-3278
> Project: Apache Knox
> Issue Type: Task
> Components: KnoxShell
> Affects Versions: 3.0.0
> Reporter: Tamás Marcinkovics
> Assignee: Tamás Marcinkovics
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Update jline.version to 3.30.6.
>
> Groovy also needs to be updated to version 5, as groovysh 4 still uses jline2.
> [https://groovy-lang.org/changelogs/changelog-5.0.0.html]
> GROOVY-8162: Update Groovysh to JLine3
> https://issues.apache.org/jira/browse/GROOVY-8162)
> AspectJ for JDK17 needs to be upgraded to 1.9.21.1+:
> [https://github.com/eclipse-aspectj/aspectj/blob/master/docs/release/README-1.9.22.adoc]
> JNA needs to be updated.
> [https://mvnrepository.com/artifact/org.apache.groovy/groovy-groovysh/5.0.4/dependencies]
> net.java.dev.jna:jna:5.18.1
> org.apache.groovy:groovy:5.0.4
> org.jline:jansi:3.30.6
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
