[
https://issues.apache.org/jira/browse/KNOX-3335?focusedWorklogId=1023052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1023052
]
ASF GitHub Bot logged work on KNOX-3335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/26 07:24
Start Date: 01/Jun/26 07:24
Worklog Time Spent: 10m
Work Description: Raghav-Mah3shwari opened a new pull request, #1245:
URL: https://github.com/apache/knox/pull/1245
What changes were proposed in this pull request?
This PR adds local pylint linting for Python integration tests under
.github/workflows/tests/ and fixes existing pylint violations so the suite
passes cleanly.
Linting infrastructure
Added .pylintrc with test-friendly settings (100-char line limit, common
test-docstring rules disabled).
Added run_pylint.sh to lint changed or staged .py files under
.github/workflows/tests/; creates a local venv (.venv/) and installs
requirements.txt plus pylint.
Updated README.md with a Linting (pylint) section covering manual runs and
optional git hook setup.
Code quality fixes
Resolved pylint issues across all integration test modules and
common_utils.py (line length, trailing whitespace, trailing newlines).
All files under .github/workflows/tests/ now score 10.00/10 with the new
config.
No functional changes to test logic — only style and lint tooling.
How was this patch tested?
Pylint (manual)
./.github/workflows/tests/run_pylint.sh
Result: all test_*.py and common_utils.py pass at 10.00/10.
Pylint (targeted)
cd .github/workflows/tests
.venv/bin/pylint --rcfile=.pylintrc -j 0 test_*.py common_utils.py
Result: exit code 0, no violations.
Script behavior
Verified run_pylint.sh creates .venv/ on first run and reuses it on
subsequent runs.
Verified it only lints files under .github/workflows/tests/ that are
modified or staged.
Integration Tests
No new integration tests were added. This change is lint tooling and style
fixes for the existing Docker Compose test suite.
Existing tests in .github/workflows/tests/ were not changed in behavior. To
confirm they still pass end-to-end:
docker compose -f ./.github/workflows/compose/docker-compose.yml build
knox-dev tests
docker compose -f ./.github/workflows/compose/docker-compose.yml up -d
docker compose -f ./.github/workflows/compose/docker-compose.yml up
--exit-code-from tests tests
UI changes
N/A — no UI changes.
Issue Time Tracking
-------------------
Worklog Id: (was: 1023052)
Remaining Estimate: 0h
Time Spent: 10m
> Add pylint pre-push linting for .github/workflows/tests Python integration
> tests
> --------------------------------------------------------------------------------
>
> Key: KNOX-3335
> URL: https://issues.apache.org/jira/browse/KNOX-3335
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Raghav Maheshwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add local pylint checks for Python files under {{.github/workflows/tests/}}
> so modified integration test code is validated before push. Pylint should run
> only on changed files in that directory, not across the whole Knox codebase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
