[
https://issues.apache.org/jira/browse/KNOX-3335?focusedWorklogId=1023997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1023997
]
ASF GitHub Bot logged work on KNOX-3335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/26 03:37
Start Date: 08/Jun/26 03:37
Worklog Time Spent: 10m
Work Description: Raghav-Mah3shwari commented on PR #1245:
URL: https://github.com/apache/knox/pull/1245#issuecomment-4645207755
Hi @moresandeep ,
Beyond .pylintrc, run_pylint.sh, and style fixes, there are docker-compose
and workflow changes to enforce pylint in CI:
**Why docker-compose changed**
Previously, the tests service used python:3.9-slim, bind-mounted ../tests,
and only ran pytest. There was no lint step in CI.
We now run pylint in the tests container before pytest, so every PR that
runs Apache Knox Docker Compose Tests fails on lint violations — no optional
git hook required.
**Why the images changed**
apache/knox-compose-tests:local (new): built from tests/Dockerfile with
pylint, .pylintrc, and test sources baked in. Needed so CI has pylint available
and lints the same code it tests.
apache/knox-dev:${IMAGE_TAG:-master} (unchanged role): still the Knox
runtime for ldap/knox; CI builds this as before.
knox-dev-local (optional, local dev only): builds Knox from source via
Dockerfile.local not used by CI.
**Other compose tweaks**
tests.yml now builds knox-dev and tests (was knox-dev only).
Knox logs use a named volume instead of ./logs bind-mount (more reliable on
Docker Desktop).
Removed runtime pip install from the tests command
In a summary we can say that local lint (run_pylint.sh) = fast developer
feedback; compose/CI lint = mandatory gate for all PRs.
Issue Time Tracking
-------------------
Worklog Id: (was: 1023997)
Time Spent: 50m (was: 40m)
> Add pylint pre-push linting for .github/workflows/tests Python integration
> tests
> --------------------------------------------------------------------------------
>
> Key: KNOX-3335
> URL: https://issues.apache.org/jira/browse/KNOX-3335
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Raghav Maheshwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add local pylint checks for Python files under {{.github/workflows/tests/}}
> so modified integration test code is validated before push. Pylint should run
> only on changed files in that directory, not across the whole Knox codebase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
