Raghav-Mah3shwari opened a new pull request, #1245: URL: https://github.com/apache/knox/pull/1245
What changes were proposed in this pull request? This PR adds local pylint linting for Python integration tests under .github/workflows/tests/ and fixes existing pylint violations so the suite passes cleanly. Linting infrastructure Added .pylintrc with test-friendly settings (100-char line limit, common test-docstring rules disabled). Added run_pylint.sh to lint changed or staged .py files under .github/workflows/tests/; creates a local venv (.venv/) and installs requirements.txt plus pylint. Updated README.md with a Linting (pylint) section covering manual runs and optional git hook setup. Code quality fixes Resolved pylint issues across all integration test modules and common_utils.py (line length, trailing whitespace, trailing newlines). All files under .github/workflows/tests/ now score 10.00/10 with the new config. No functional changes to test logic — only style and lint tooling. How was this patch tested? Pylint (manual) ./.github/workflows/tests/run_pylint.sh Result: all test_*.py and common_utils.py pass at 10.00/10. Pylint (targeted) cd .github/workflows/tests .venv/bin/pylint --rcfile=.pylintrc -j 0 test_*.py common_utils.py Result: exit code 0, no violations. Script behavior Verified run_pylint.sh creates .venv/ on first run and reuses it on subsequent runs. Verified it only lints files under .github/workflows/tests/ that are modified or staged. Integration Tests No new integration tests were added. This change is lint tooling and style fixes for the existing Docker Compose test suite. Existing tests in .github/workflows/tests/ were not changed in behavior. To confirm they still pass end-to-end: docker compose -f ./.github/workflows/compose/docker-compose.yml build knox-dev tests docker compose -f ./.github/workflows/compose/docker-compose.yml up -d docker compose -f ./.github/workflows/compose/docker-compose.yml up --exit-code-from tests tests UI changes N/A — no UI changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
