handavid commented on code in PR #1240:
URL: https://github.com/apache/knox/pull/1240#discussion_r3351904272
##########
gateway-server/src/main/resources/conf/gateway-site.xml:
##########
@@ -68,61 +68,76 @@ limitations under the License.
<description>Path to JSON data file for file-based backend. Supports
${GATEWAY_DATA_HOME} variable.</description>
</property>
- <!-- LDAP backend proxy configuration (active when
gateway.ldap.backend.type=ldap) -->
+ <!-- LDAP backend proxy configuration (active when
gateway.ldap.interceptor.names includes ldapproxy) -->
+ <property>
+ <name>gateway.ldap.interceptor.ldapproxy.backendType</name>
+ <value>ldap</value>
+ <description>Backend type for LDAP service. Currently supported: file,
ldap. Future: jdbc, knox.</description>
+ </property>
<property>
- <name>gateway.ldap.backend.ldap.url</name>
+ <name>gateway.ldap.interceptor.ldapproxy.url</name>
<value>ldap://localhost:33389</value>
<description>LDAP server URL for proxy backend</description>
</property>
<property>
- <name>gateway.ldap.backend.ldap.remoteBaseDn</name>
+ <name>gateway.ldap.interceptor.ldapproxy.remoteBaseDn</name>
<value>dc=hadoop,dc=apache,dc=org</value>
<description>Base DN of the remote LDAP server</description>
</property>
<property>
- <name>gateway.ldap.backend.ldap.systemUsername</name>
+ <name>gateway.ldap.interceptor.ldapproxy.systemUsername</name>
<value>uid=guest,ou=people,dc=hadoop,dc=apache,dc=org</value>
<description>LDAP bind DN for proxy backend
authentication</description>
</property>
<property>
- <name>gateway.ldap.backend.ldap.systemPassword</name>
+ <name>gateway.ldap.interceptor.ldapproxy.systemPassword</name>
<value>guest-password</value>
<description>LDAP bind password for proxy backend
authentication</description>
</property>
<!-- Backend-specific configuration using prefixed properties -->
- <!-- Uncomment and configure based on backend type specified in
gateway.ldap.backend.type -->
+ <!-- Uncomment and configure based on interceptor names specified in
gateway.ldap.interceptor.names -->
- <!-- File backend configuration (gateway.ldap.backend.type=file) -->
+ <!-- File backend configuration
(gateway.ldap.interceptor.<interceptorName>.backendType=file) -->
<!--
<property>
- <name>gateway.ldap.backend.file.dataFile</name>
+ <name>gateway.ldap.interceptor.ldapfile.backendType</name>
+ <value>ldap</value>
+ <description>Backend type for LDAP service. Currently supported: file,
ldap. Future: jdbc, knox.</description>
+ </property>
+ <property>
+ <name>gateway.ldap.interceptor.ldapfile.dataFile</name>
<value>${GATEWAY_DATA_HOME}/ldap-users.json</value>
<description>Path to JSON file containing user and group
data</description>
</property>
-->
- <!-- LDAP proxy backend configuration (gateway.ldap.backend.type=ldap) -->
+ <!-- LDAP proxy backend configuration
(gateway.ldap.interceptor.<interceptorName>.backendType=ldap) -->
<!-- This backend proxies to an external LDAP server (e.g., demo LDAP) -->
<!--
Example 1: Using Knox demo LDAP server (default port 33389)
Review Comment:
I'm fixing the existing configs here for my config changes. should we remove
the whole ldap proxy-related block?
I was waiting for https://github.com/apache/knox/pull/1227 to be merged
before updating the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
