smolnar82 commented on PR #1240:
URL: https://github.com/apache/knox/pull/1240#issuecomment-4647676361
I also asked Gemini to focus on the test coverage. Here is the output. I
removed some of the items as they are irrelevant for now (I know you'll be
working on the "generalization" of the attributes to support not only
user/group related searches):
```
While the PR introduces good unit tests for the new components, several
critical areas remain under-tested or completely uncovered.
1. Missing Test Scenarios
* Partition ID Collisions: The logic interceptorName.replaceAll("\\s+",
"") is prone to collisions. There are no tests ensuring that providing names
like "My LDAP" and "MyLDAP" won't cause the server to fail during
initialization.
* Interceptor Ordering: The PR relies on the order of names in
`gateway.ldap.interceptor.names`. There are no tests verifying that putting
`duplicatefilter` before a backend interceptor correctly results in no
deduplication of backend results (confirming "sink" behavior).
2. Error Handling Resilience
* Partial Failures: If multiple backends are configured and one is
unreachable, the system's behavior is untested. Does the entire search fail, or
does it gracefully continue to the next interceptor?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
