lmccay commented on code in PR #1257:
URL: https://github.com/apache/knox/pull/1257#discussion_r3398964100
##########
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/AbstractIdentityAssertionFilter.java:
##########
@@ -147,6 +148,11 @@ protected void
continueChainAsPrincipal(HttpServletRequestWrapper request, Servl
final Set<TokenIdPrincipal> tokenIdPrincipals =
SubjectUtils.getTokenIdPrincipals(currentSubject);
subject.getPrincipals().addAll(tokenIdPrincipals);
+ // RFC 8693 Token Exchange: Preserve ActorChainPrincipal from the
current subject
+ // This ensures the delegation chain is maintained through identity
assertion
+ final Set<ActorChainPrincipal> actorChainPrincipals =
currentSubject.getPrincipals(ActorChainPrincipal.class);
Review Comment:
Got it. One liner which may be why I didn't bother before but it is
consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
