moresandeep commented on code in PR #1291:
URL: https://github.com/apache/knox/pull/1291#discussion_r3538694668
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -818,6 +818,45 @@ public String getHttpClientTruststorePasswordAlias() {
return get(HTTP_CLIENT_TRUSTSTORE_PASSWORD_ALIAS,
DEFAULT_HTTP_CLIENT_TRUSTSTORE_PASSWORD_ALIAS);
}
+ @Override
+ public String getHttpClientKeystorePath() {
+ return get(HTTP_CLIENT_KEYSTORE_PATH);
+ }
+
+ @Override
+ public String getHttpClientKeystoreType() {
+ return get(HTTP_CLIENT_KEYSTORE_TYPE, DEFAULT_HTTP_CLIENT_KEYSTORE_TYPE);
+ }
+
+ @Override
+ public String getHttpClientKeystorePasswordAlias() {
+ return get(HTTP_CLIENT_KEYSTORE_PASSWORD_ALIAS,
DEFAULT_HTTP_CLIENT_KEYSTORE_PASSWORD_ALIAS);
+ }
+
+ @Override
+ public String getHttpClientKeyAlias() {
+ return get(HTTP_CLIENT_KEY_ALIAS, DEFAULT_HTTP_CLIENT_KEY_ALIAS);
+ }
+
+ @Override
+ public String getHttpClientKeyPassphraseAlias() {
+ return get(HTTP_CLIENT_KEY_PASSPHRASE_ALIAS,
DEFAULT_HTTP_CLIENT_KEY_PASSPHRASE_ALIAS);
+ }
+
+ @Override
+ public boolean isSingleEkuEnabled() {
+ return getBoolean(TLS_SINGLE_EKU_ENABLED, DEFAULT_TLS_SINGLE_EKU_ENABLED);
+ }
+
+ @Override
+ public boolean isHttpClientTwoWaySslEnabled() {
+ String configured = get(HTTP_CLIENT_TWO_WAY_SSL_ENABLED);
+ if (configured != null) {
+ return Boolean.parseBoolean(configured);
Review Comment:
Yeah, this method intends to fall back to `isSingleEkuEnabled()` this is
because, for single EKU feature to work two-way-ssl is required as a result if
two-way-ssl is not configured we default it to `isSingleEkuEnabled()`.
So, if someone turned on `isSingleEkuEnabled()` then they not need to
specifically turn on two-way-ssl as those go hand in hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
