moresandeep commented on code in PR #1291:
URL: https://github.com/apache/knox/pull/1291#discussion_r3553950520
##########
gateway-spi/src/main/java/org/apache/knox/gateway/services/security/KeystoreService.java:
##########
@@ -34,6 +34,15 @@ public interface KeystoreService extends Service {
void addSelfSignedCertForGateway(String alias, char[] passphrase, String
hostname) throws KeystoreServiceException;
+ /**
+ * Adds a self-signed certificate to the Gateway keystore, stamping the
given Extended Key Usage
+ * purpose OIDs (single-EKU identities). The default implementation ignores
the OIDs.
+ */
+ default void addSelfSignedCertForGateway(String alias, char[] passphrase,
String hostname, String... ekuOids)
Review Comment:
Yes, it now supports adding self-signed single-EKU certs. It delegates to
the original impl in case ekuOids is balnk/null so this is a non-breaking
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
