moresandeep commented on code in PR #1291:
URL: https://github.com/apache/knox/pull/1291#discussion_r3553987953
##########
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java:
##########
@@ -201,6 +212,11 @@ SSLContext createSSLContext(GatewayServices services,
FilterConfig filterConfig,
trustKeystore = identityKeystore;
Review Comment:
THis does not look like a part of this PR, looks like it might have gotten
shifted due to the changes. Looks like it is a fallback for when no outbound
HTTP client truststore is configured then getTruststoreForHttpClient() returns
null when gateway.httpclient.truststore.path isn't set. In that case we fall
back to using its identity keystore as the trust material.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
