[
https://issues.apache.org/jira/browse/KNOX-3390?focusedWorklogId=1031802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1031802
]
ASF GitHub Bot logged work on KNOX-3390:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/26 08:56
Start Date: 23/Jul/26 08:56
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #1319:
URL: https://github.com/apache/knox/pull/1319#discussion_r3636781768
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/knoxidf/trustedoidcissuer/JdbcTrustedOidcIssuerService.java:
##########
@@ -195,6 +202,35 @@ private synchronized void reloadRegistrySnapshot() {
registrySnapshot.set(Collections.unmodifiableMap(fresh));
} catch (Exception e) {
LOG.errorReloadingRegistrySnapshot(e.getMessage(), e);
+ throw new RuntimeException("Error reloading trusted OIDC issuer registry
snapshot", e);
}
}
+
+ /**
+ * Canonicalizes an issuer URL for registry storage and lookup by stripping
a single
+ * trailing slash, so that {@code https://issuer.example.com/} and
+ * {@code https://issuer.example.com} are treated as the same issuer. This
matches the
+ * trailing-slash stripping {@link OIDCDiscoveryHelper} already applies when
building the
+ * discovery URL. Null-safe.
+ */
+ private static String normalizeIssuerUrl(String issuerUrl) {
Review Comment:
I'm fine with this as long as we understood that there might be a possible
mismatch while verifying the issuer claim in the JWT for a trusted issuer. Let
me close this one and merge #1320 .
Issue Time Tracking
-------------------
Worklog Id: (was: 1031802)
Time Spent: 1h (was: 50m)
> Address comments in PR 1315
> ---------------------------
>
> Key: KNOX-3390
> URL: https://issues.apache.org/jira/browse/KNOX-3390
> Project: Apache Knox
> Issue Type: Sub-task
> Components: Server
> Affects Versions: 3.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 3.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
