[
https://issues.apache.org/jira/browse/KNOX-3390?focusedWorklogId=1031977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1031977
]
ASF GitHub Bot logged work on KNOX-3390:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/26 07:37
Start Date: 24/Jul/26 07:37
Worklog Time Spent: 10m
Work Description: hsheinblatt commented on code in PR #1322:
URL: https://github.com/apache/knox/pull/1322#discussion_r3643723971
##########
gateway-server/src/test/java/org/apache/knox/gateway/services/knoxidf/trustedoidcissuer/JdbcTrustedOidcIssuerServiceTest.java:
##########
@@ -234,13 +234,9 @@ public void testMaxTrustedIssuers() throws
ServiceLifecycleException {
limitedService.register(issuer("https://b.example.com";, false));
assertEquals("Second registration must succeed", 2,
limitedService.list().size());
- try {
Review Comment:
Generally I prefer to use the try/catch with fail rather than an expected
exception in any test that makes more than one call. In this case there are
several calls to limitedService. With the general expected exception, you don't
know where the exception came from, it could have happened well before you
intend.
Issue Time Tracking
-------------------
Worklog Id: (was: 1031977)
Time Spent: 2h 10m (was: 2h)
> Address comments in PR 1315
> ---------------------------
>
> Key: KNOX-3390
> URL: https://issues.apache.org/jira/browse/KNOX-3390
> Project: Apache Knox
> Issue Type: Sub-task
> Components: Server
> Affects Versions: 3.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 3.1.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
