As I said, if you hadn't already pushed it then I would say change it. If you have already pushed it - which I think you have - then no sense changing it again until you have remove the hack anyway. At which point, it would also make sense to make a getConfigValue method that can be reused.
On Tue, Dec 10, 2013 at 7:07 PM, Dilli Arumugam (JIRA) <[email protected]>wrote: > > [ > https://issues.apache.org/jira/browse/KNOX-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844848#comment-13844848] > > Dilli Arumugam commented on KNOX-217: > ------------------------------------- > > Thank You for the clarification. > > I interpret this as, you would prefer the logic to add credentials in > ShiroDeploymentContributor rather than KnoxLdapContextFactory. Please > correct me if I have misunderstood. > > When we thin about it, even contributors should not be adding credentials > based on environment variable. > It should the the admin adding credentials using some tool explicitly. > Given that, not sure whether the temporary work around being in > KnoxLdapRealm versus ShiroDeploymentContributor makes a significant > difference. > > If you still prefer that way, please confirm. I would make the change. > > > > > enhance KnoxLdapGroupRealm to accept password alias in place of plain > text password > > > ----------------------------------------------------------------------------------- > > > > Key: KNOX-217 > > URL: https://issues.apache.org/jira/browse/KNOX-217 > > Project: Apache Knox > > Issue Type: Sub-task > > Components: Server > > Affects Versions: 0.4.0 > > Reporter: Dilli Arumugam > > Assignee: Dilli Arumugam > > Fix For: 0.4.0 > > > > Attachments: KNOX-217.patch > > > > > > > > > -- > This message was sent by Atlassian JIRA > (v6.1.4#6159) >
