In https://gerrit.cloudera.org/#/c/4435/, Tidy Bot said:
Line 209: // TODO: Should be fixed with Exactly Once semantics,
see KUDU-1537.
warning: missing username/bug in TODO [google-readability-todo]
// TODO: Should be fixed with Exactly Once semantics, see KUDU-1537.
^
// TODO(unknown): Should be fixed with Exactly Once semantics,
see KUDU-1537.
This doesn't look like the kind of style change we want, right?
Historically we don't annotate our TODOs with names.
Or should I reformat it as "TODO(KUDU-1537)..." ?
On Wed, Sep 14, 2016 at 10:04 PM, Todd Lipcon <[email protected]> wrote:
> Hey folks,
>
> I've set up a jenkins job and gerrit trigger to run clang-tidy-diff on any
> patches that are uploaded. It should be set up now so as not to vote +1 or
> -1, but just to produce comments. For an example of the type of warnings it
> generates, check out:
> https://gerrit.cloudera.org/#/c/4409/4/src/kudu/consensus/raft_consensus_state.h
>
> If you see any checks that you think are false positives, feel free to ping
> me and I can either disable those checks entirely, or see if there's some
> configuration we can make to better match our own guidelines.
>
> Hopefully this turns out to be a useful bit of "automatic code review" so
> that we can focus our review efforts less on mechanical checks and more on
> things requiring human judgment :) If it turns out to be more of an
> annoyance than a help, we can always remove it or really dial back to only
> the most important warnings.
>
> Also worth noting that these checks are not that complicated to write, so
> if we see that there are some Kudu-specific ones worth implementing, we can
> easily do so.
>
> -Todd
> --
> Todd Lipcon
> Software Engineer, Cloudera
