Hey folks, I've set up a jenkins job and gerrit trigger to run clang-tidy-diff on any patches that are uploaded. It should be set up now so as not to vote +1 or -1, but just to produce comments. For an example of the type of warnings it generates, check out: https://gerrit.cloudera.org/#/c/4409/4/src/kudu/consensus/raft_consensus_state.h
If you see any checks that you think are false positives, feel free to ping me and I can either disable those checks entirely, or see if there's some configuration we can make to better match our own guidelines. Hopefully this turns out to be a useful bit of "automatic code review" so that we can focus our review efforts less on mechanical checks and more on things requiring human judgment :) If it turns out to be more of an annoyance than a help, we can always remove it or really dial back to only the most important warnings. Also worth noting that these checks are not that complicated to write, so if we see that there are some Kudu-specific ones worth implementing, we can easily do so. -Todd -- Todd Lipcon Software Engineer, Cloudera
