I'd like to get "Address alter_table_randomized-test flakyness on ResultTracker" https://gerrit.cloudera.org/#/c/4629/ merged in. Rare race but potential for SIGSEGV on a highly battered cluster. Patch/fix/bug is simple enough that side-effects are very unlikely if not impossible.
-david On Thu, Oct 6, 2016 at 12:12 PM, Dan Burkert <[email protected]> wrote: > I'll make sure we release a new build of the website since a lot of docs > have changed. My understanding is that this can be decoupled from the > actual release branch, so doc-only changes don't need to be backported. > > There has been a big effort over the last week and a half to pay down some > of the flaky tests. This has resulted in some new bug fix patches which > are not (as of now) included in the 1.0.1 branch: > > * mem_tracker: fix race between FindTracker() and destructor > <https://github.com/apache/kudu/commit/64f9ab34ffbc249cf72fc187308a14 > 02888ba994> > * [java client] Tight-ish loop in master lookups if a tablet doesn't ha… > <https://github.com/apache/kudu/commit/d87486c47153cfc42c5a8ed7496e74 > 6aafdc2bdd> > * KUDU-1681: DNS resolution failure of master hostname causes tserver crash > <https://gerrit.cloudera.org/#/c/4640/> > * Address alter_table_randomized-test flakyness on ResultTracker > <https://gerrit.cloudera.org/#/c/4629/> > * log: address a heap overflow race during log roll > <https://gerrit.cloudera.org/#/c/4638/> > > Of these, I believe only KUDU-1681 has been observed outside of tests. Any > thoughts/opinions on adding some or all of these to the 1.0.1 release? > > - Dan > > On Wed, Oct 5, 2016 at 9:17 AM, Mike Percy <[email protected]> wrote: > > > Dan thanks for RMing! > > > > I think it would be useful to also pull in docs patches that seem to have > > missed 1.0.0 like d6c5507049757735cc88659f919a5a5d12092da6 > > and fcbfa90e4a594c473901297a47dfa2d01f1229e1 > > > > Mike > > > > On Tue, Oct 4, 2016 at 1:12 AM, Dan Burkert <[email protected]> > wrote: > > > > > Reminder that we are going to cut the 1.0.1 RC this Friday. If you > have > > > any additional patches you want to include now is the time to speak up. > > > Besides the issues already discussed, the following should make the > cut: > > > > > > KUDU-1660 / 69e657 > > > <https://github.com/apache/kudu/commit/69e65780843040c085ca34901803b9 > > > 7b59595c0e>: > > > Kudu fails to start up on single CPU system > > > KUDU-1652 part 2 <https://gerrit.cloudera.org/#/c/4612/> > > > > > > - Dan > > > > > > On Tue, Sep 27, 2016 at 11:22 AM, Dan Burkert <[email protected]> > > > wrote: > > > > > > > Yep, I can take care of that. > > > > > > > > - Dan > > > > > > > > On Tue, Sep 27, 2016 at 11:21 AM, Todd Lipcon <[email protected]> > > wrote: > > > > > > > >> Sounds good. Are you going to take care of cherry-picking these > items > > to > > > >> branch-1.0.x? We also need a commit to reset the version in that > > branch > > > to > > > >> 1.0.1-SNAPSHOT during the dev period. > > > >> > > > >> On Tue, Sep 27, 2016 at 11:11 AM, Dan Burkert < > [email protected]> > > > >> wrote: > > > >> > > > >> > Fixes have landed for KUDU-1651 > > > >> > <https://github.com/apache/kudu/commit/ > > 1f40913de6d3427847f3d435e1b84f > > > >> > b928a6f6a9> > > > >> > and KUDU-1652 > > > >> > <https://github.com/apache/kudu/commit/ > > ce17a9c4eb34dcfe63c8d4321d38d1 > > > >> > 8a0cb8c5c2>, > > > >> > so every outstanding known issue > > > >> > that we want to address has a committed fix in master. Since many > > > people > > > >> > are > > > >> > otherwise busy with the Strata conference this week, I think we > > should > > > >> > stick to > > > >> > the original plan to cut an RC on October 7th, with a potential > > > release > > > >> > date the > > > >> > following week. If any further bugs arise before the 7th we can > > > consider > > > >> > them > > > >> > for inclusion. Thanks all. > > > >> > > > > >> > - Dan > > > >> > > > > >> > On Mon, Sep 26, 2016 at 11:18 AM, Adar Dembo <[email protected]> > > > wrote: > > > >> > > +1 to a patch release. > > > >> > > > > > >> > > My only opinion on the nominated patches is that I'm not sure if > > we > > > >> > > need to include the KUDU-1090 fix. IIRC it was very rare and > > > generally > > > >> > > only contributed to test flakiness. But, I'm fine with including > > it > > > if > > > >> > > others feel strongly. > > > >> > > > > > >> > > On Mon, Sep 26, 2016 at 10:55 AM, Todd Lipcon < > [email protected]> > > > >> wrote: > > > >> > >> +1 for a bug fix release, especially to address the known crash > > > bugs. > > > >> > I'll > > > >> > >> add one more to the running: > > > >> > >> > > > >> > >> https://gerrit.cloudera.org/#/c/4535/ > > > >> > >> > > > >> > >> This fixes a crash when running on single-core systems. Again > not > > > too > > > >> > >> common (even most VMs have two cores these days) but it can be > a > > > >> blocker > > > >> > if > > > >> > >> you need to run on a single-core. > > > >> > >> > > > >> > >> -Todd > > > >> > >> > > > >> > >> On Mon, Sep 26, 2016 at 10:49 AM, Dan Burkert < > > > [email protected] > > > >> > > > > >> > wrote: > > > >> > >> > > > >> > >>> Hi all, > > > >> > >>> > > > >> > >>> Since the 1.0.0 release there have been a few issues found > which > > > may > > > >> > >>> warrant a bug fix on the 1.0.x line. I'd like to get the ball > > > >> rolling > > > >> > and > > > >> > >>> figure out what we might want to include in a bug release, if > we > > > >> decide > > > >> > to > > > >> > >>> go ahead with a bug release fix. > > > >> > >>> > > > >> > >>> Potential inclusions: > > > >> > >>> > > > >> > >>> KUDU-1652 <https://issues.apache.org/jira/browse/KUDU-1652>: > > > >> Partition > > > >> > >>> pruning / scan optimization fails with IS NOT NULL predicate > on > > PK > > > >> > column > > > >> > >>> KUDU-1651 <https://issues.apache.org/jira/browse/KUDU-1651>: > > > >> tserver > > > >> > crash > > > >> > >>> when pushing predicate on dict encoded block with all null > > values > > > >> > >>> 8fc75a5c65 > > > >> > >>> <https://github.com/apache/kudu/commit/8fc75a5c654e100871316 > > > >> e61878b14 > > > >> > >>> 1df4707d0e>: > > > >> > >>> [java > > > >> > >>> client] Fix an NPE in KuduException > > > >> > >>> 9911c489 > > > >> > >>> <https://github.com/apache/kudu/commit/9911c489c45b3a261ee50 > > > >> ad1f83738 > > > >> > >>> 7b4953421b> > > > >> > >>> KUDU-1623 <https://issues.apache.org/jira/browse/KUDU-1623>: > > > >> Properly > > > >> > >>> handle UPSERTS that only include PK column > > > >> > >>> b0b273e8 > > > >> > >>> <https://github.com/apache/kudu/commit/b0b273e8271752b6eb04b > > > >> a163981aa > > > >> > >>> d1c792e413>: > > > >> > >>> [java client] make DateFormat safe to use > > > >> > >>> 1eb2418 > > > >> > >>> <https://github.com/apache/kudu/commit/1eb24183a540f4e3bbbc8 > > > >> a399e440e > > > >> > >>> cf905f6129>: > > > >> > >>> consensus: properly truncate all state when aborting > operations > > > >> > >>> KUDU-1090 <https://issues.apache.org/jira/browse/KUDU-1090> > > > 4b9d2f6 > > > >> > >>> <https://github.com/apache/kudu/commit/4b9d2f6976f45ea57e9a2 > > > >> c2648f31b > > > >> > >>> 3a0941a569>: > > > >> > >>> relax > > > >> > >>> MemTracker uniqueness constraint > > > >> > >>> > > > >> > >>> It would also be nice to fix the Java client's client2tablet > > > >> > >>> synchronization / memory leak issue, but I'm not sure of the > > > proper > > > >> set > > > >> > of > > > >> > >>> patches to backport. JD/David, do you have any insight on > that? > > > >> > >>> > > > >> > >>> Please reply with any other commits that you would like to > > > include. > > > >> > >>> > > > >> > >>> Most of these issues are extremely rare, or easily worked > around > > > (or > > > >> > both), > > > >> > >>> but I think in aggregate they represent enough sharp edges > that > > > >> waiting > > > >> > for > > > >> > >>> a 1.1 release may be painful. > > > >> > >>> > > > >> > >>> Since a few of these issues don't have a patch committed or > even > > > in > > > >> > review > > > >> > >>> yet, an RC probably can't be cut before the end of next week > > > >> (October > > > >> > >>> 7th). I volunteer to RM this one. What does everyone think? > > > >> > >>> > > > >> > >>> - Dan > > > >> > >>> > > > >> > >> > > > >> > >> > > > >> > >> > > > >> > >> -- > > > >> > >> Todd Lipcon > > > >> > >> Software Engineer, Cloudera > > > >> > > > > >> > > > >> > > > >> > > > >> -- > > > >> Todd Lipcon > > > >> Software Engineer, Cloudera > > > >> > > > > > > > > > > > > > >
