Mike Percy has posted comments on this change. Change subject: Only release memory to OS when overhead is unacceptable ......................................................................
Patch Set 1: (1 comment) Nice find! http://gerrit.cloudera.org:8080/#/c/1711/1/src/kudu/util/mem_tracker.cc File src/kudu/util/mem_tracker.cc: Line 496: while (extra > 0) { Seems susceptible to TOCTOU, in case there is a large allocation in the middle of this loop. How expensive is the GetNumericProperty call? -- To view, visit http://gerrit.cloudera.org:8080/1711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I184c9b7c64a57d4cd178fe7cfb2c548e323edecb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
