Adar Dembo has posted comments on this change. Change subject: Only release memory to OS when overhead is unacceptable ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1711/2/src/kudu/util/mem_tracker.cc File src/kudu/util/mem_tracker.cc: Line 57: DEFINE_int32(tcmalloc_max_free_bytes_percentage, 10, Sorry, forgot to mention this in the first round, but we should validate that the user's value is a real percentage (i.e. between 0 and 100). Same goes for memory_limit_warn_threshold_percentage, too, though that's not your fault. -- To view, visit http://gerrit.cloudera.org:8080/1711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I184c9b7c64a57d4cd178fe7cfb2c548e323edecb Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
