Todd Lipcon has posted comments on this change. Change subject: cmake: add support for out-of-tree builds ......................................................................
Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/1755/13/.gitignore File .gitignore: Line 11 don't we still expect ctags/cscope stuff to be in the source tree? at least I think emacs typically puts that stuff there http://gerrit.cloudera.org:8080/#/c/1755/13//COMMIT_MSG Commit Message: Line 44: a cmake target, so I was forced to use file(COPY...), which executes the I thought in the current rev it does a symlink? http://gerrit.cloudera.org:8080/#/c/1755/13/README.adoc File README.adoc: Line 27: uild directories may be anywhere in the filesystem : except for in the sour hrm, thought I commented on this but maybe not -- this should more specifically say that the build dir may not be identical to the source directory itself (it may be inside it) http://gerrit.cloudera.org:8080/#/c/1755/13/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 118: TEST_LOGDIR="$BUILD_ROOT/test-logs" just to confirm: this nets out to the same directory so we shouldn't have to change the Jenkins configs for where to look for junit xmls, right? -- To view, visit http://gerrit.cloudera.org:8080/1755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e17a1102b79ac0e25a505b54347db3bb436ede Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
