Mike Percy has posted comments on this change. Change subject: cmake: add support for out-of-tree builds ......................................................................
Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/1755/13/docs/installation.adoc File docs/installation.adoc: Line 243: thirdparty/installed/bin/cmake .. -DCMAKE_BUILD_TYPE=release -DCMAKE_INSTALL_PREFIX=/opt/kudu Here, and elsewhere, should be ../thirdparty http://gerrit.cloudera.org:8080/#/c/1755/13/docs/support/scripts/make_docs.sh File docs/support/scripts/make_docs.sh: Cool. Did you test the docs changes? http://gerrit.cloudera.org:8080/#/c/1755/13/docs/support/scripts/make_site.sh File docs/support/scripts/make_site.sh: Did you test this? Line 39: BUILD_ROOT Hmm. Why is it necessary to blow away the whole build directory? -- To view, visit http://gerrit.cloudera.org:8080/1755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e17a1102b79ac0e25a505b54347db3bb436ede Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
