Dan Burkert has posted comments on this change.

Change subject: Use thirdparty libstdcxx stdlib headers during TSAN build
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/1880/1/CMakeLists.txt
File CMakeLists.txt:

Line 268:   # Some of the above also need to be passed to the linker.
> Can you expand this comment to talk about how, for TSAN, we need to switch 
Done


http://gerrit.cloudera.org:8080/#/c/1880/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 179:     # does not exist, setting BOOST_ROOT to the empty string has no 
effect (the
> Add "below" so it's clear the second sentence is about the actual cmake inv
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/1880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4cc858c550f6b03255dd29484abd4e9d1a42442
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to