Todd Lipcon has posted comments on this change.

Change subject: Use thirdparty libstdcxx stdlib headers during TSAN build
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1880/3/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

Line 217:   ln -sf $GCC_DIR/libgcc/gthr-posix.h $GCC_DIR/libgcc/gthr-default.h
I'm surprised this happens during the 'unpack' step and not in 
build-thirdparty. (this won't run if there's already a gcc dir present)


-- 
To view, visit http://gerrit.cloudera.org:8080/1880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4cc858c550f6b03255dd29484abd4e9d1a42442
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to