Todd Lipcon has posted comments on this change. Change subject: Fix flakiness of client_failover-itest ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/1952/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1848: *DCHECK_NOTNULL(id) = state_->GetCommittedOpIdUnlocked(); for future wire-compat, should actually check for the UNKNOWN case too and return a bad status, right? http://gerrit.cloudera.org:8080/#/c/1952/1/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 699: SleepFor(kTimeout); hrm, you replaced a 10ms sleep with a 10sec sleep here? oops? http://gerrit.cloudera.org:8080/#/c/1952/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 85: #define RETURN_HANDLE_UNKNOWN_ERROR(s, resp, ctx) \ hrm, this is only used once - not sure it really clarifies things -- To view, visit http://gerrit.cloudera.org:8080/1952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ea7523e212c1b0f67b1498ba5139e4c5537519 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
