I think something is wrong with the test running infrastructure. I got an error involving missing tsan symbols on a debug build.
Mike On Wednesday, February 3, 2016, Mike Percy (Code Review) <[email protected]> wrote: > Hello Kudu Jenkins, > > I'd like you to reexamine a change. Please visit > > http://gerrit.cloudera.org:8080/1952 > > to look at the new patch set (#3). > > Change subject: Fix flakiness of client_failover-itest > ...................................................................... > > Fix flakiness of client_failover-itest > > The reason this test was flaky is that there is a race between > determining that all of the replicas in a config have replicated an opid > and that opid being committed. We were also missing the > --master_add_server_when_underreplicated=false flag on the test, causing > a race between the master and the test driver. > > This patch exposes getting the committed OpId from Consensus as an RPC > (previously, only the last replicated opid was exposed). It also adds a > helper function for testing purposes to wait until a specific OpId has > been committed. > > Looped 100x and they all passed: > http://dist-test.cloudera.org/job?job_id=mpercy.1454486819.10566 > > Change-Id: I56ea7523e212c1b0f67b1498ba5139e4c5537519 > --- > M src/kudu/consensus/consensus.h > M src/kudu/consensus/consensus.proto > M src/kudu/consensus/raft_consensus-test.cc > M src/kudu/consensus/raft_consensus.cc > M src/kudu/consensus/raft_consensus.h > M src/kudu/integration-tests/client_failover-itest.cc > M src/kudu/integration-tests/cluster_itest_util.cc > M src/kudu/integration-tests/cluster_itest_util.h > M src/kudu/integration-tests/raft_consensus-itest.cc > M src/kudu/integration-tests/tablet_replacement-itest.cc > M src/kudu/integration-tests/ts_itest-base.h > M src/kudu/tserver/tablet_service.cc > 12 files changed, 119 insertions(+), 44 deletions(-) > > > git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/1952/3 > -- > To view, visit http://gerrit.cloudera.org:8080/1952 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: newpatchset > Gerrit-Change-Id: I56ea7523e212c1b0f67b1498ba5139e4c5537519 > Gerrit-PatchSet: 3 > Gerrit-Project: kudu > Gerrit-Branch: master > Gerrit-Owner: Mike Percy <[email protected] <javascript:;>> > Gerrit-Reviewer: Kudu Jenkins > Gerrit-Reviewer: Todd Lipcon <[email protected] <javascript:;>> > -- -- Mike Percy Software Engineer, Cloudera
