David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] - Allow to get the projection schema from the scanner ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2026/2/src/kudu/client/client.h File src/kudu/client/client.h: Line 1029: KuduSchema GetProjectionSchema() const; > Why are we returning a copy and not a const* ? Cuz it might change (i.e. if the user changes the projection before the scanner is open) and because this will be called rarely enough that it is likely not a problem. -- To view, visit http://gerrit.cloudera.org:8080/2026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc33761749df11e78a76d88dac244a00501e42d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
