David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] - Allow to get the projection schema from the scanner ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2026/3/src/kudu/client/client.h File src/kudu/client/client.h: Line 1029: KuduSchema GetProjectionSchema() const; > hrm, curious about the wisdom of this being a copy vs a const pointer retur as I replied to adar I made this a copy as this might change before Open() if SetProjectedColumns is called, and since this can be called only one for the entire lifetime of the scanner it shouldn't be a big perf problem. if you fell strongly about it I can make it a const pointer instead. -- To view, visit http://gerrit.cloudera.org:8080/2026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc33761749df11e78a76d88dac244a00501e42d Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
