Dan Burkert has posted comments on this change. Change subject: Add TypeInfo::AreConsecutive(a, b) ......................................................................
Patch Set 1: Normally equality predicates are specified as EQUAL typed (https://github.com/cloudera/kudu/blob/master/src/kudu/client/scan_predicate.h#L38), so it shouldn't be a problem for them. It is a problem for LESS_EQUAL predicates, and in that case there is a ColumnPredicate constructor fn that returns an optional: https://github.com/danburkert/kudu/blob/KUDU-1165-take-2/src/kudu/common/column_predicate.h#L76. -- To view, visit http://gerrit.cloudera.org:8080/2136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64b8ffb5400be1132e400385a5995849874100b2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
