Dan Burkert has posted comments on this change. Change subject: Add TypeInfo::AreConsecutive(a, b) ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2136/1/src/kudu/common/types-test.cc File src/kudu/common/types-test.cc: Line 91: ASSERT_EQ(get<2>(test_case), info->AreConsecutive(&get<0>(test_case), &get<1>(test_case))); > a SCOPED_TRACE here which stringifies the tuple would be pretty handy, othe Done -- To view, visit http://gerrit.cloudera.org:8080/2136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64b8ffb5400be1132e400385a5995849874100b2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
