Adar Dembo has posted comments on this change.

Change subject: thirdparty: llvm build should clear old artifacts
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2539/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 78:   # The LLVM build can fail if a different version is already installed
Would it be too drastic to blow away everything under $PREFIX (and all 
variants) before doing a "full" rebuild of thirdparty? That is, one where you 
didn't specify a particular component when you ran build-thirdparty.sh?

Ideally "build foo" would remove all of $PREFIX/.../foo*, but maybe that's too 
annoying to do manually for each component.


Line 80:   # of the one being build.
Nit: being built.


-- 
To view, visit http://gerrit.cloudera.org:8080/2539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida093005e2d68d0413b1244c53c4d94208590944
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to