Adar Dembo has posted comments on this change. Change subject: thirdparty: llvm build should clear old artifacts ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2539/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 78: # The LLVM build can fail if a different version is already installed > I suppose it's reasonable, except that it would really annoy me because I o If you're willing to do it separately for each component, I think you'll get the best of both worlds, because if you explicitly do nothing for cmake, you have "enough time" to Ctrl-C before the build makes it to LLVM. But in general, I think we should address your issue differently. For interactive builds, you could imagine producing a diff or git log of what changed in thirdparty and prompting the user whether it should be rebuilt or skipped. -- To view, visit http://gerrit.cloudera.org:8080/2539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida093005e2d68d0413b1244c53c4d94208590944 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
