Todd Lipcon has posted comments on this change. Change subject: KUDU-1410 (part 3): rpc: look up the RpcMethodInfo from the reactor ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2796/5/src/kudu/rpc/inbound_call.cc File src/kudu/rpc/inbound_call.cc: Line 273: // overflow, etc. These cases should not be counted against the histogram. > Nit: missing end parens here. Done Line 279: if (hist) { > Isn't 'hist' guaranteed to exist if 'method_info_' also exists, since 'hist Done -- To view, visit http://gerrit.cloudera.org:8080/2796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bed4917ca05f46c829d1733270bfba3ec20d699 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
