Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1410 (part 3): rpc: look up the RpcMethodInfo from the reactor ......................................................................
KUDU-1410 (part 3): rpc: look up the RpcMethodInfo from the reactor This makes the reactor code look up the RpcMethodInfo associated with a call, and moves the latency histogram collection code into the InboundCall class instead of RpcContext. This cleans up RpcContext so now it is only responsible for user-facing APIs and not responsible for collecting metrics. This change may also be useful in the future if we want to start queueing calls differently based on the particular method being invoked. We now have an easy way for the RPC service definition to propagate up appropriate attributes all the way to the reactor. Change-Id: I1bed4917ca05f46c829d1733270bfba3ec20d699 Reviewed-on: http://gerrit.cloudera.org:8080/2796 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/inbound_call.h M src/kudu/rpc/messenger.cc M src/kudu/rpc/protoc-gen-krpc.cc M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/rpc_service.h M src/kudu/rpc/service_if.cc M src/kudu/rpc/service_if.h M src/kudu/rpc/service_pool.cc M src/kudu/rpc/service_pool.h 11 files changed, 85 insertions(+), 34 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bed4917ca05f46c829d1733270bfba3ec20d699 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
