Adar Dembo has posted comments on this change. Change subject: Bump up some default timeouts ......................................................................
Patch Set 2: (4 comments) Please make a pass over the various client-using tests (both C++ and Java) and remove any timeout overrides that are no longer necessary. These include overrides that make the test less flaky, but that are now actually less forgiving than the default timeouts. http://gerrit.cloudera.org:8080/#/c/2872/2/docs/release_notes.adoc File docs/release_notes.adoc: Line 81: operation and admin timeouts Nit: "operation and admin timeouts" aren't actual things; to be more precise, it's the "default operation timeout" and the "default admin operation timeout". Line 81: new Nit: just say longer Line 82: It's : the same Nit: "It" is ambiguous. Does it refer to the fact that the C++ client also has new default timeouts? Does it refer to the operation/admin timeouts? Does it refer to the default socket read timeout? http://gerrit.cloudera.org:8080/#/c/2872/2/src/kudu/client/client.h File src/kudu/client/client.h: Line 879: // Default scanner timeout. : // This is set to 3x the default RPC timeout (see KuduClientBuilder::default_rpc_timeout()). : enum { kScanTimeoutMillis = 15000 }; This probably needs to be adjusted too. -- To view, visit http://gerrit.cloudera.org:8080/2872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d2faced9011256e7ec7ab16241967bee6c6dd9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
