David Ribeiro Alves has posted comments on this change. Change subject: Refactor retry handling logic for writes ......................................................................
Patch Set 7: (2 comments) adar: new rev still doesn't address your comments http://gerrit.cloudera.org:8080/#/c/2970/7/src/kudu/rpc/replicated_rpc.h File src/kudu/rpc/replicated_rpc.h: Line 22: // Result status of a replicated Rpc. > What is a "replicated" RPC? Why is it useful to constrain this object to on I called them replicated because they target a replicated resource (tablet, master) and is meant to summarize the errors that can occur when talking to "replicas" Line 23: struct ReplicatedRpcStatus { > At first I expected that this and ScanRpcStatus overlapped, but now I see t Not sure, likely not. I see us using this for "writes" in the broad sense (like TS::Write() but also Master::CreateTable()) -- To view, visit http://gerrit.cloudera.org:8080/2970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0d491f902191c88c58e3d627106cc1be1bb3cc Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
