David Ribeiro Alves has posted comments on this change. Change subject: Refactor retry handling logic for writes ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2970/8/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: Line 78: s = Status::NetworkError("No addresses for " + hp.ToString()); > a test case for this functional change would be nice. Can we inject DNS res Can't find an easy way to do this. We could call this callback method directly and make sure it returns NetworkError instead of NotFound, but not sure it's worth it. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/2970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0d491f902191c88c58e3d627106cc1be1bb3cc Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
