Todd Lipcon has posted comments on this change. Change subject: Add metrics for tcmalloc spinlock contention ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3007/1/src/kudu/util/spinlock_profiling.cc File src/kudu/util/spinlock_profiling.cc: Line 70: struct PaddedAtomic64 { > Why is it important to pad this struct so it fills an entire cache line? Done Line 71: Atomic64 val; > Why Atomic64 and not AtomicInt<T> or std::atomic? Done http://gerrit.cloudera.org:8080/#/c/3007/1/src/kudu/util/trace_metrics.h File src/kudu/util/trace_metrics.h: Line 81: lock_guard<simple_spinlock> l(&lock_); > You can release the lock right after the local copy of counters_ is made. Done -- To view, visit http://gerrit.cloudera.org:8080/3007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6ed322541b161e6d9e347e0d75e62d1b6b05ec Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
