Todd Lipcon has posted comments on this change. Change subject: Add metrics for tcmalloc spinlock contention ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3007/1/src/kudu/util/spinlock_profiling.cc File src/kudu/util/spinlock_profiling.cc: Line 71: Atomic64 val; > Done oh wait, not done -- the reasoning is that this struct is declared as a static, so it can't have non-POD fields, and AtomicInt<> doesn't have a default constructor. We can't lazily allocate it like we do g_contended_cycles, because then we'd need to use the allocator. -- To view, visit http://gerrit.cloudera.org:8080/3007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6ed322541b161e6d9e347e0d75e62d1b6b05ec Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
