Adar Dembo has posted comments on this change. Change subject: service_queue: use futex for waking waiting rpc threads ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/2940/5/src/kudu/rpc/service_queue.h File src/kudu/rpc/service_queue.h: Line 27: #include "kudu/gutil/atomicops.h" Nit: resort. Line 183: return call_; Why don't we need to nullify call_ before returning like we did before? Line 191: DCHECK_EQ(old, NOT_BLOCKED); Seems a little self-explanatory, given the semantics of CAS. Line 205: enum State { Would be nice to see a few comments explaining the significance of ConsumerState being in any one of these states. -- To view, visit http://gerrit.cloudera.org:8080/2940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7bb703d643b722f732f4c4ebc391d25796d3df Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
