Todd Lipcon has posted comments on this change. Change subject: service_queue: use futex for waking waiting rpc threads ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2940/5/src/kudu/rpc/service_queue.cc File src/kudu/rpc/service_queue.cc: Line 61: if (call != nullptr) { > Actually, moving it causes a crash during ServicePool::Shutdown(). The issu I gave prefetch() a try and couldn't measure any difference in rpc-bench performance. I'll leave it as is for now http://gerrit.cloudera.org:8080/#/c/2940/5/src/kudu/rpc/service_queue.h File src/kudu/rpc/service_queue.h: Line 183: return call_; > Yeah, but Reset() is only called on the subequent Wait(). A successful Wait shouldn't be an issue, because it's just a pointer (doesn't imply any ownership) and we only look at call_ right there. -- To view, visit http://gerrit.cloudera.org:8080/2940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7bb703d643b722f732f4c4ebc391d25796d3df Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
