Adar Dembo has posted comments on this change. Change subject: Refactor retry handling logic for writes ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2970/7/src/kudu/rpc/replicated_rpc.h File src/kudu/rpc/replicated_rpc.h: Line 22: // Result status of a replicated Rpc. > OK, but scans also target replicas, and yet ReplicatedRpcStatus doesn't app I still think this needs to be addressed in some way. At the very least, your response to my question should find its way into the comment here. But beyond that, it's imprecise to say this status is for RPCs targeting replicas when scans also target replicas and don't use this (and won't use it). -- To view, visit http://gerrit.cloudera.org:8080/2970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0d491f902191c88c58e3d627106cc1be1bb3cc Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
