David Ribeiro Alves has posted comments on this change. Change subject: Add an all-virtual ServerPicker class and a meta cache backed implementation ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3017/4/src/kudu/rpc/replicated_rpc.h File src/kudu/rpc/replicated_rpc.h: Line 45: class ReplicaPicker : public RefCountedThreadSafe<ReplicaPicker<Replica>> { > I just found it odd that an interface (ReplicaPicker) stipulates that every the problem is that ReplicatedRpc (next patch) is the one to hold the reference to the picker and it doesn't necessarily know the implementation so if this wasn't a scoped_refptr it would have to hold a raw pointer or we'd have to pass the whole scoped_refptr as a template argument, which would be worse imo. -- To view, visit http://gerrit.cloudera.org:8080/3017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id43db316606cb807ec0019c79b3bdf76fa509fe5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
