David Ribeiro Alves has submitted this change and it was merged. Change subject: Add an all-virtual ServerPicker class and a meta cache backed implementation ......................................................................
Add an all-virtual ServerPicker class and a meta cache backed implementation This pulls out the replica picking code from WriteRpc and into an implementation of the new ServerPicker, all-virtual class. The new server picker implementation, which is backed by the meta cache, fully readies the replica before handing it over to WriteRpc. This makes the writing logic simpler (less callbacks) and makes the replica picking code possibly reusable. Again, this is just a refactor of existing code so no new tests were added. Change-Id: Id43db316606cb807ec0019c79b3bdf76fa509fe5 Reviewed-on: http://gerrit.cloudera.org:8080/3017 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/client/batcher.cc M src/kudu/rpc/rpc.h 2 files changed, 272 insertions(+), 149 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id43db316606cb807ec0019c79b3bdf76fa509fe5 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
