Todd Lipcon has posted comments on this change. Change subject: Move the MetaCacheServerPicker into meta_cache.h/cc ......................................................................
Patch Set 12: Code-Review+1 (1 comment) is this just a move, then? there's the new member and getter, but I dont see it getting initialized/used unless I missed something? http://gerrit.cloudera.org:8080/#/c/3028/12/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: Line 131: virtual void PickLeader(const ServerPickedCallback& callback, const MonoTime& deadline) OVERRIDE; nit: now that we are c++11, you can use 'override' directly, and thne you don't need to also say 'virtual' since it's redundant (and lint will complain if you use both) -- To view, visit http://gerrit.cloudera.org:8080/3028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5344e9556f7042743458efbf1a5dc8be1e45f8da Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
