Adar Dembo has posted comments on this change.
Change subject: Move the MetaCacheServerPicker into meta_cache.h/cc
......................................................................
Patch Set 13:
It's a shame that moving the picker into RemoteTablet didn't work out, but
after talking about it with you I at least understand how the KuduTable
lifecycle presents problems.
Perhaps we should defer this code motion till later? The MetaCache backs this
picker and that makes meta_cache.{cc,h} attractive, but it's also only ever
used in batcher.cc. So neither location is a slam dunk, and that makes the code
motion just noise to me.
--
To view, visit http://gerrit.cloudera.org:8080/3028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5344e9556f7042743458efbf1a5dc8be1e45f8da
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No
