Todd Lipcon has posted comments on this change. Change subject: Add unique id generation to the client ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3077/1//COMMIT_MSG Commit Message: Line 10: enra typo Line 13: ted typo http://gerrit.cloudera.org:8080/#/c/3077/1/src/kudu/client/client.h File src/kudu/client/client.h: Line 255: const std::string& client_id() const; is this necessary to be public? would rather avoid a new public API unless we have a clear use case http://gerrit.cloudera.org:8080/#/c/3077/1/src/kudu/client/client_builder-internal.cc File src/kudu/client/client_builder-internal.cc: Line 28: client_id_ = oid_generator.Next(); curious why you are plumbing this through the builder instead of just generating it in the client data constructor itself? seems like this would be fewer lines of code http://gerrit.cloudera.org:8080/#/c/3077/1/src/kudu/integration-tests/client-stress-test.cc File src/kudu/integration-tests/client-stress-test.cc: Line 292: pair<set<string>::iterator, bool> result = client_ids.insert(client_id); auto here -- To view, visit http://gerrit.cloudera.org:8080/3077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie752ab8337cc76c3be1536958c24a8b6c5794650 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
