David Ribeiro Alves has posted comments on this change. Change subject: Add unique id generation to the client ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3077/1//COMMIT_MSG Commit Message: Line 10: enra > typo Done Line 13: ted > typo Done http://gerrit.cloudera.org:8080/#/c/3077/1/src/kudu/client/client.h File src/kudu/client/client.h: Line 255: const std::string& client_id() const; > is this necessary to be public? would rather avoid a new public API unless Was thinking we could use this to do something like we do for tablets, where we output the the id of the tablet on log messages and have appropriate macros for it. We can do it later/some other way though. Done http://gerrit.cloudera.org:8080/#/c/3077/1/src/kudu/client/client_builder-internal.cc File src/kudu/client/client_builder-internal.cc: Line 28: client_id_ = oid_generator.Next(); > curious why you are plumbing this through the builder instead of just gener Done http://gerrit.cloudera.org:8080/#/c/3077/1/src/kudu/integration-tests/client-stress-test.cc File src/kudu/integration-tests/client-stress-test.cc: Line 292: pair<set<string>::iterator, bool> result = client_ids.insert(client_id); > auto here Done -- To view, visit http://gerrit.cloudera.org:8080/3077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie752ab8337cc76c3be1536958c24a8b6c5794650 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
