Adar Dembo has posted comments on this change. Change subject: KUDU-678. Avoid orphaning empty REDO delta blocks ......................................................................
Patch Set 1: Code-Review+2 (1 comment) Note that aborting a writable block is not an atomic process. Basically the block is "finished" as per the usual procedure (though we avoid any fsyncs), then we delete it. If we crash in between, we'll orphan the block. It's not the worst thing in the world, but something we should improve on in the future. http://gerrit.cloudera.org:8080/#/c/3100/1/src/kudu/tablet/deltafile-test.cc File src/kudu/tablet/deltafile-test.cc: Line 379: ASSERT_TRUE(s.IsAborted()); Should we also check that fs_manager_->OpenBlock(test_block) returns NotFound? -- To view, visit http://gerrit.cloudera.org:8080/3100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c2a084959cb6cffeafa8b0984fcac4ae12ae04 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
