Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-678. Avoid orphaning empty REDO delta blocks ......................................................................
KUDU-678. Avoid orphaning empty REDO delta blocks In the somewhat-common case that a DiskRowSet is written with no REDOs, we would previously leak a very small delta block. This addresses this long-standing TODO by aborting the block in the case that nothing was written. Change-Id: Ic8c2a084959cb6cffeafa8b0984fcac4ae12ae04 Reviewed-on: http://gerrit.cloudera.org:8080/3100 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/cfile/cfile_writer.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/diskrowset.cc M src/kudu/tserver/tablet_server-test.cc 6 files changed, 45 insertions(+), 15 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8c2a084959cb6cffeafa8b0984fcac4ae12ae04 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
